[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHv3] erc: fix erc-reuse-buffers behavior

From: Amin Bandali
Subject: Re: [PATCHv3] erc: fix erc-reuse-buffers behavior
Date: Mon, 03 Aug 2020 11:14:35 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Thanks for the patch, Matthew.

I just noticed Lars installed 6f94c2405f4c82b63da19de89549aff1fad7e594
on master, changing erc-generate-new-buffer-name.  Will your patch
require adjusting to accommodate Lars's changes?

Minor nits:

- Please omit the "Signed-off-by:" from your commit messages to Emacs.
- Consider dropping the second "* lisp/erc/erc.el" for (erc-cmd-JOIN),
  since the previous entry (erc-generate-new-buffer-name) was also a
  change to lisp/erc/erc.el.


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]