[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] TTY Support for ECMA-48 strike-through graphic rendition
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] TTY Support for ECMA-48 strike-through graphic rendition |
Date: |
Tue, 11 Aug 2020 22:17:08 +0300 |
> From: Mike Hamrick <mikeh@muppetlabs.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 26 Jun 2020 12:23:48 -0700
>
> I've updated my patch to include a NEWS item. I grepped through the
> manual looking for areas that might need updating, and did not find
> any.
Thanks, a couple of really minor nits below:
> @@ -1971,7 +1974,8 @@ turn_off_face (struct frame *f, int face_id)
> if (face->tty_bold_p
> || face->tty_italic_p
> || face->tty_reverse_p
> - || face->tty_underline_p)
> + || face->tty_underline_p
> + || face->tty_strike_through_p)
Please use our style of indentation in C source files (basically, make
sure indent-tabs-mode is non-nil).
Also, please make sure the patch still applies to the current master,
and if not, please update it.
Thanks.
- Re: [PATCH] TTY Support for ECMA-48 strike-through graphic rendition,
Eli Zaretskii <=