[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 262d0c6: Mark some tests as expensive

From: Michael Albinus
Subject: Re: master 262d0c6: Mark some tests as expensive
Date: Fri, 18 Sep 2020 12:31:44 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Stefan Kangas <stefan@marxist.se> writes:

Hi Stefan,

> It does seem unfortunate that no tests run for autorevert-mode in the
> default case.  I have a patch in the works that will reduce the running
> time for these tests, I will send it here when it's done.  (Basically
> the patch would temporarily lower auto-revert-interval, remove sleeps
> and manually set mtime to lower values than the current time.)

Would be helpful. However, there have been discussions (and changes) of
the timeouts in the past, so I'm not sure we can reduce them w/o causing
damage. Please check the git history of autorevert-tests.el for such
changes, hopefully there are bug numbers in the git log you could consult
for the respective discussions. Otherwise, a search on the emacs-devel
and emacs-bugs MLs for the given timeframe of such a change might be helpful.

>> There have been discussions about how long tests shall run. But there
>> hasn't been ever a conclusion to limit them to 1 second. Please discuss
>> this first, before making such changes.
> Sure, I just didn't expect this to be controversial.  Sorry if this
> change caused any problems.

IIRC, this discussion happened before you've started with work on
Emacs. I'm pretty sure there's something in the emacs-devel ML, but this
was years ago.

> Best regards,
> Stefan Kangas

Best regards, Michael.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]