[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix some failing tests in BSD systems
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] Fix some failing tests in BSD systems |
Date: |
Mon, 04 Jan 2021 05:30:30 +0200 |
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Mon, 4 Jan 2021 03:41:20 +0200
>
> On 03.01.2021 19:35, Eli Zaretskii wrote:
> > Why are we producing file names by concatenation, instead of calling
> > expand-file-name? Wouldn't using the latter solve the problem? Or
> > what did I miss?
>
> While we sometimes do that (expand-file-name is not free, and for
> certain uses its overhead counts), that doesn't seem to be the case here.
Not sure what you mean: I clearly saw calls to concat in the patch,
both in the old and the new code. What did I miss?
> The double slash here is produced by an external program, not by
> concatenation.
I understand that much, but expand-file-name removes the double
slashes as part of its job, doesn't it?
- [PATCH] Fix some failing tests in BSD systems, Daniel Martín, 2021/01/03
- Re: [PATCH] Fix some failing tests in BSD systems, Eli Zaretskii, 2021/01/03
- Re: [PATCH] Fix some failing tests in BSD systems, Daniel Martín, 2021/01/03
- Re: [PATCH] Fix some failing tests in BSD systems, Dmitry Gutov, 2021/01/03
- Re: [PATCH] Fix some failing tests in BSD systems,
Eli Zaretskii <=
- Re: [PATCH] Fix some failing tests in BSD systems, Dmitry Gutov, 2021/01/04
- Re: [PATCH] Fix some failing tests in BSD systems, Eli Zaretskii, 2021/01/04
- Re: [PATCH] Fix some failing tests in BSD systems, Dmitry Gutov, 2021/01/04
- Re: [PATCH] Fix some failing tests in BSD systems, Daniel Martín, 2021/01/04
- Re: [PATCH] Fix some failing tests in BSD systems, Dmitry Gutov, 2021/01/05
- Re: [PATCH] Fix some failing tests in BSD systems, Daniel Martín, 2021/01/06
- Re: [PATCH] Fix some failing tests in BSD systems, Dmitry Gutov, 2021/01/06
- Re: [PATCH] Fix some failing tests in BSD systems, Stefan Monnier, 2021/01/06
- Re: [PATCH] Fix some failing tests in BSD systems, Dmitry Gutov, 2021/01/06
Re: [PATCH] Fix some failing tests in BSD systems, Dmitry Gutov, 2021/01/03