[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix some failing tests in BSD systems

From: Dmitry Gutov
Subject: Re: [PATCH] Fix some failing tests in BSD systems
Date: Mon, 4 Jan 2021 15:10:40 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 04.01.2021 05:30, Eli Zaretskii wrote:
Cc: emacs-devel@gnu.org
From: Dmitry Gutov <dgutov@yandex.ru>
Date: Mon, 4 Jan 2021 03:41:20 +0200

On 03.01.2021 19:35, Eli Zaretskii wrote:
Why are we producing file names by concatenation, instead of calling
expand-file-name?  Wouldn't using the latter solve the problem?  Or
what did I miss?

While we sometimes do that (expand-file-name is not free, and for
certain uses its overhead counts), that doesn't seem to be the case here.

Not sure what you mean: I clearly saw calls to concat in the patch,
both in the old and the new code.  What did I miss?

The changes you are referring to are both in the test code. There's nothing inherently wrong in using concat in such code, as long as we test what we want to test.

The double slash here is produced by an external program, not by

I understand that much, but expand-file-name removes the double
slashes as part of its job, doesn't it?

Yes, so?

If you actually meant to suggest an alternative comparison strategy (like in Daniel's latest patch), then I think the test becomes unnecessarily lax. After all, we want to also check how the string "looks" (because the user will see it verbatim), not just what file it points at.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]