[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [External] : Consistent face for keys in *Help* and `substitute-comm
From: |
Drew Adams |
Subject: |
RE: [External] : Consistent face for keys in *Help* and `substitute-command-keys' |
Date: |
Wed, 24 Feb 2021 22:01:00 +0000 |
> > I think you already knew that I've been doing this
> > in help-fns+.el for over a decade. I've offered
> > the code before, and we've discussed it. It uses
> > `help-substitute-command-keys':
>
> I admit that I have never used any of your libraries.
>
> But I have seen Bug#8951 and the code you presented there.
>
> > That is, keys are linked to their commands.
> > So their face is the face Emacs uses for links.
> >
> > I think that's the right (better) approach.
>
> I'm not convinced of that. There will be many links all
> over the place, sometimes many links to the same place.
Why do you think so? I haven't seen that.
> It risks cluttering the help screen too much,
> whereas the effect you see with my patch is
> more subtle.
What makes you think your highlighting is more
subtle? And more subtle than what? You just
said that you've never even tried help-fns+.el.
> I also don't know of too many examples where
> links will be highly useful.
Specifics, please. Show an example where a
`...' key link isn't useful.
> Still, I'm not writing off the idea completely,
> I just don't currently see how to balance the drawbacks.
What drawbacks? So far, you've talked only
abstractly, about things that don't exist.
> > That's already been solved.
>
> Care to elaborate? AFAICT, messages do not currently
> display keybindings in a different face.
I meant that `...' for keys in *Help* is solved.
And the key listings you speak of there (e.g.
C-h C-h), which do _not_ use `...', can be dealt
with separately. That help (e.g. `C-h h') is
constructed individually - it doesn't use doc
strings or `substitute-command-keys'.
> > You can start with the code in help-fns+.el.
> > Or you can start from scratch. But DTRT.
>
> The work is mostly to identify the places where we output keys and
> ensure the strings get the correct face properties applied to them.
> Therefore, it is unfortunately not much help to start from anything
> that is not the Emacs source code or a patch to the Emacs source code.
And yet that's what you've done with other parts
of help-fns+.el... Suit yourself.
My point is that it's more helpful to users to
put links on those keys, in addition to keys
wrapped with `...'.
- Proposal for an improved `help-for-help', Stefan Kangas, 2021/02/21
- RE: [External] : Proposal for an improved `help-for-help', Drew Adams, 2021/02/21
- Re: Proposal for an improved `help-for-help', Lars Ingebrigtsen, 2021/02/21
- RE: [External] : Re: Proposal for an improved `help-for-help', Drew Adams, 2021/02/21
- Re: Proposal for an improved `help-for-help', Stefan Kangas, 2021/02/21
- Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/02/23
- RE: [External] : Consistent face for keys in *Help* and `substitute-command-keys', Drew Adams, 2021/02/23
- RE: [External] : Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/02/23
- RE: [External] : Consistent face for keys in *Help* and `substitute-command-keys',
Drew Adams <=
- RE: [External] : Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/02/24
- RE: [External] : Consistent face for keys in *Help* and `substitute-command-keys', Drew Adams, 2021/02/25
- Re: [External] : Consistent face for keys in *Help* and `substitute-command-keys', Eli Zaretskii, 2021/02/25
- RE: [External] : Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/02/25
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Basil L. Contovounesios, 2021/02/24
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/02/24
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Basil L. Contovounesios, 2021/02/24
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/02/24
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Lars Ingebrigtsen, 2021/02/24
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Eli Zaretskii, 2021/02/24