[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: woman.el broken?

From: Stefan Kangas
Subject: Re: woman.el broken?
Date: Wed, 3 Mar 2021 08:19:44 -0600

Eli Zaretskii <eliz@gnu.org> writes:

> If this is performant enough, I don't at the moment see any reason to
> have it in C.  Of course, the few places that call Flookup_key from C
> will need to be analyzed whether they need to call the internal
> function or the Lisp wrapper, and modified accordingly.

OK.  I will write up the patch and do some benchmarks.

>>     (defun lookup-key (keymap key accept-default)
>>       (or (lookup-key-internal keymap key accept-default)
>>           (and (vectorp key)
>>                (let ((lc-key `[,@(mapcar
>>                                   (lambda (s)
>>                                     (intern (downcase (symbol-name s))))
>>                                   key)]))
>>                  (when (not (equal lc-key key))
>>                    (lookup-key-internal keymap lc-key accept-default))))))
> This is not the only transformation we should apply, IMO: we should
> also convert "Foo Bar Baz" into "foo-bar-baz".  See the Dired menus
> for examples.

Yes, I will add that too.

For "Foo Bar Baz", is it enough to look for "foo-bar-baz" or would we
need to look for both "Foo-Bar-Baz" as well?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]