[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Simple isearch concerns

From: Juri Linkov
Subject: Re: Simple isearch concerns
Date: Tue, 06 Apr 2021 21:53:31 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

> Sorry, there was a typo in the previous patch, I attach a corrected one.

Thanks, please see the comments below:

> +(put 'beginning-of-buffer 'isearch-match-scroll t)
> +(put 'end-of-buffer 'isearch-match-scroll t)
> +(put 'scroll-up-command 'isearch-match-scroll t)
> +(put 'scroll-down-command 'isearch-match-scroll t)
> +
> +(put 'beginning-of-buffer 'isearch-match-scroll-command 
> 'isearch-beginning-of-buffer)
> +(put 'end-of-buffer 'isearch-match-scroll-command 'isearch-end-of-buffer)
> +(put 'scroll-up-command 'isearch-match-scroll-command 'isearch-scroll-up)
> +(put 'scroll-down-command 'isearch-match-scroll-command 'isearch-scroll-down)

Why such unnecessary duplication?  When 'beginning-of-buffer' has the
property 'isearch-match-scroll-command' this means it has a non-nil value.
There is no need to duplicate this fact with isearch-match-scroll=t.

> +  :type '(choice (const :tag "Off" nil)
> +                 (const tag "On" t))

reply via email to

[Prev in Thread] Current Thread [Next in Thread]