[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] `completing-read`: Add `group-function` support to completio

From: Juri Linkov
Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2)
Date: Sat, 01 May 2021 22:54:28 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

>> Aren't affixations guarded by completions-detailed
>> and grouping guarded by completions-group orthogonal?
>> Then it should be fine to have separate options.
> Yes, they are orthogonal. I agree we can keep it as is. I still wanted
> to point it out. And note the difference - the completions-group guard
> variable is checked in minibuffer.el, while the completions-detailed
> variable is checked in the completion table in help-fns.el. Maybe
> completions-detailed should also be checked in the minibuffer.el instead?

I think both completions-detailed and completions-group should be
checked only by the API user like in help-fns.el.  Otherwise,
there is duplication that you can see in my previous patch
for read-char-by-name:

  (let* ((enable-recursive-minibuffers t)
         (completion-ignore-case t)
         (completion-tab-width 4)
         (completions-group read-char-by-name-group)
           (lambda (string pred action)
             (if (eq action 'metadata)
                    . ,(when read-char-by-name-group

The same user option read-char-by-name-group is checked twice.
It should suffice to leave only the latter.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]