Re: Semantic hl-line-mode (was: ELPA: add lin.el)

[Protesilaos Stavrou]

On 2021-11-10, 16:33 +0200, Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Protesilaos Stavrou <info@protesilaos.com>
>> Date: Wed, 10 Nov 2021 16:14:33 +0200
>> Cc: emacs-devel <emacs-devel@gnu.org>
>> 
>> Following your advice, I have prepared a patch for hl-line.el.  Please
>> find it attached.  Feel welcome to make changes.
>
> [... 22 lines elided]
>
> I've read this text and the other documentation in the patch, and I
> still don't understand what this does and how it differs from the
> default operation of hl-line.  You describe quite a lot of
> implementation-elated details, but very little information that can
> help the user decide whether he or she wants this option.  I think one
> problem (but not the only one) is that you use "selection", which is
> an overloaded term (you definitely do NOT mean X selections, right?).
>
> Could you please rework the documentation so that it becomes more
> user-facing?

Thank you Eli for the feedback!  I have tried to clarify the language
and avoid the term "selection", opting instead for "line-oriented user
interfaces".

Patch attached.

On 2021-11-10, 06:53 -0800, Stefan Kangas <stefankangas@gmail.com> wrote:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> +Major modes can register themselves as having a selection-based
>>> +interface by setting the local variable 'hl-line-select-line-style' to
>>> +non-nil.  In that case, they will use the new 'hl-line-selection'
>>> +face.
> [snip]
>> Could you please rework the documentation so that it becomes more
>> user-facing?
>
> I'd propose two entries, and put one of them under "Lisp changes" to
> describe what major modes need to do to use this new functionality by
> default.

Thank you Stefan!  I followed your advice in documenting those.

-- 
Protesilaos Stavrou
https://protesilaos.com

0001-Add-line-oriented-style-for-hl-line-mode.patch
Description: Text Data