Re: Request: Please add a prompt to read-event

[Stefan Monnier]

Lars Ingebrigtsen [2021-12-18 08:39:04] wrote:

> "T.V Raman" <raman@google.com> writes:
>
>> Emacspeak advices read-event and read-char to speak their
>> prompt. There are a few places in Emacs where read-event and/or
>> read-char  are called without a prompt; e.g. disabled-command-function
>>
>> Could we perhaps fix this?
>
> [...]
>
>>      (message "Type y, n, ! or SPC (the space bar): ")
>>      (let ((cursor-in-echo-area t))
>>        (while (progn (setq char (read-event))
>>                   (or (not (numberp char))
>>                       (not (memq (downcase char)
>>                                  '(?! ?y ?n ?\s ?\C-g)))))
>>       (ding)
>>       (message "Please type y, n, ! or SPC (the space bar): "))))
>
> Hm...  that is pretty odd.  Why is it using `message' here instead of
> just using that string as the prompt to `read-event'?

This code dates back to 1989.  It would benefit from a bit of
modernization, such as making it use `read-multiple-choice`.


        Stefan