emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Findirect_function


From: Manuel Giraud
Subject: Re: [PATCH] Findirect_function
Date: Fri, 14 Jan 2022 14:00:34 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix)

Mattias EngdegÄrd <mattiase@acm.org> writes:

> 14 jan. 2022 kl. 11.40 skrev Manuel Giraud <manuel@ledu-giraud.fr>:
>
>> Maybe it is bike shedding territory (and maybe I'm missing something)
>
> Not at all, patches are always welcome!

Thanks.

[...]

> Good! See if you can find more instances of this unfortunate
> pattern. Even if it makes no difference for the generated code (very
> likely), it obfuscates the source code.

Ok, I'll look for this kind of pattern.

> The other changes are less obvious since they may introduce extra
> costs; some of these code paths are fairly hot. In addition, I'm
> giving part of the interpreter an overhaul so perhaps we could drop
> them for the time being. Do you agree?

Yes it is one more C function call. Sure you could drop it!
-- 
Manuel Giraud



reply via email to

[Prev in Thread] Current Thread [Next in Thread]