[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Findirect_function
From: |
Stefan Monnier |
Subject: |
Re: [PATCH] Findirect_function |
Date: |
Fri, 14 Jan 2022 11:27:30 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
> /* Optimize for no indirection. */
> - if (SYMBOLP (fun) && !NILP (fun)
> - && (fun = XSYMBOL (fun)->u.s.function, SYMBOLP (fun)))
> - {
> - fun = indirect_function (fun);
> - if (NILP (fun))
> - /* Let funcall get the error. */
> - fun = args[0];
> - }
> + fun = Findirect_function(fun, Qt);
> + if (NILP (fun))
> + /* Let funcall get the error. */
> + fun = args[0];
This should remove the corresponding comment.
And I think I'd only be willing to make such a change if it comes with
some benchmarking showing that this optimization does not actually make
a difference.
Stefan
- [PATCH] Findirect_function, Manuel Giraud, 2022/01/14
- Re: [PATCH] Findirect_function, Mattias EngdegÄrd, 2022/01/14
- Re: [PATCH] Findirect_function, Eli Zaretskii, 2022/01/14
- Re: [PATCH] Findirect_function, Andreas Schwab, 2022/01/14
- Re: [PATCH] Findirect_function,
Stefan Monnier <=
- Re: [PATCH] Findirect_function, Manuel Giraud, 2022/01/14
- Re: [PATCH] Findirect_function, Stefan Monnier, 2022/01/14
- Re: [PATCH] Findirect_function, Manuel Giraud, 2022/01/17
- Re: [PATCH] Findirect_function, Stefan Monnier, 2022/01/17
- Re: [PATCH] Findirect_function, Stefan Monnier, 2022/01/17
- Re: [PATCH] Findirect_function, Po Lu, 2022/01/17