emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master c8bde5b0a3: Fix two no-X compilation warnings


From: Po Lu
Subject: Re: master c8bde5b0a3: Fix two no-X compilation warnings
Date: Wed, 23 Mar 2022 08:55:03 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux)

Lars Ingebrigtsen <larsi@gnus.org> writes:

> -  (or (stringp x-resource-name)
> +  (when (boundp 'x-resource-name)
> +    (unless (stringp x-resource-name)
>        (let (i)
>       (setq x-resource-name (copy-sequence invocation-name))
>  
>       ;; Change any . or * characters in x-resource-name to hyphens,
>       ;; so as not to choke when we use it in X resource queries.
>       (while (setq i (string-match "[.*]" x-resource-name))
> -       (aset x-resource-name i ?-))))
> +       (aset x-resource-name i ?-)))))
>  
>    ;; Setup the default fontset.
>    (create-default-fontset)

I thought the right thing to do in this particular situation was to add
a defvar form that read something like this:

(defvar x-resource-name)

Thanks.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]