emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: process-file instead of call-process in proced.el?


From: Filipp Gunbin
Subject: Re: process-file instead of call-process in proced.el?
Date: Mon, 28 Mar 2022 17:53:19 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin)

Michael, thanks for working on this,

On 27/03/2022 16:08 +0200, Michael Albinus wrote:

> +      (if (tramp-compat-funcall
> +           'tramp-send-command-and-check
> +           vec (format "\\kill -%s %d" sigcode pid))
> +          0 -1))))
> +

Can the command be a connection-local variable?.  Then the ability to
customize, existing before deprecation of proced-signal-function, would
not be lost.

>        (setq priority (number-to-string priority)))
> -  (let (failures)
> +  (let ((default-directory
> +         (if (and current-prefix-arg (stringp proced-remote-directory))
> +             proced-remote-directory temporary-file-directory))
> +        failures)

As for me, I'd leave the proced-remote-directory thing out.  IIUC, it
allows to send signals to remote processes from "normal" proced buffer,
with local default-directory (with prefix arg).  I'd be fine with
requiring user to open proced from remote directory, with
default-directory already "prepared".

Thanks.
Filipp



reply via email to

[Prev in Thread] Current Thread [Next in Thread]