Re: [PATCH] Re: etags name collision.

[Eli Zaretskii]

> Date: Mon, 11 Apr 2022 21:19:33 +0200
> From: Ergus <spacibba@aol.com>
> Cc: emacs-devel@gnu.org
> 
> >> (ctags --version) >/dev/null 2>&1 || with_ctags=no
> >>
> >> Isn't this enough?
> >
> >No, because AFAIU this test will succeed also if the installed ctags
> >is (an older version) of the program that came with (an older version)
> >of Emacs.  You need to make sure the text emitted by --version does
> >NOT include "GNU Emacs".
> >
> Now?

Seems like this idea makes some people unhappy, but anyway:

> +     (ctags --version | grep "GNU Emacs") 2>/dev/null || with_ctags=no

I think you want

   (ctags --version | grep "GNU Emacs") >/dev/null 2>&1 || with_ctags=no

here.

> -INSTALLABLES = etags${EXEEXT} ctags${EXEEXT} emacsclient${EXEEXT} $(CLIENTW) 
> \
> -               ebrowse${EXEEXT}
> +INSTALLABLES = etags${EXEEXT} emacsclient${EXEEXT} $(CLIENTW) 
> ebrowse${EXEEXT} \
> +            $(if $(with_ctags), , ctags${EXEEXT})

Isn't it easier to replace the literal "ctags" with a value computed
by the configure script, than have configure compute a flag variable,
and then use $(if ...) in the Makefile?