[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 979308b4ca 5/9: org-export-data: Concatenate strings in tempo

From: Robert Pluim
Subject: Re: master 979308b4ca 5/9: org-export-data: Concatenate strings in temporary buffer for performance
Date: Thu, 16 Jun 2022 15:33:06 +0200

>>>>> On Thu, 16 Jun 2022 14:45:26 +0200, Lars Ingebrigtsen <larsi@gnus.org> 
>>>>> said:

    Lars> Stefan Monnier <monnier@iro.umontreal.ca> writes:
    >> AFAICT this just replaces `mapconcat` with a `with-temp-buffer + dolist
    >> + insert`, so if this makes a significant performance difference, it
    >> points to a performance problem in our `mapconcat`, right?

    Lars> It looks like it shouldn't be that difficult to improve the 
    Lars> radically in the common case of FUNCTION being #'identity.  If there's
    Lars> no SEPARATOR we can just pass the arguments more or less directly on 
    Lars> Fconcat, and if there is a SEPARATOR, we just have to adjust the arg
    Lars> list.

I did some profiling of concat and similar about a year ago. One of
the things that got me some improvement was adjusting the type checks
so that the most common case came first. Of course thatʼs highly
dependent on which benchmarks you choose :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]