Re: master 979308b4ca 5/9: org-export-data: Concatenate strings in temporary buffer for performance

[Ihor Radchenko]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Ihor Radchenko [2022-06-16 20:49:27] wrote:
>> I hope that I did not get it wrong.  I _believe_ that I did see an
>> improvement. So, you better check if it makes a difference on your side
>> if you revert that patch (especially with un-optimized build where the
>> differences should be more prominent).
>
> The fact that you think you saw a significant difference is already
> a good hint that there might be something there, in any case.
> But of course, we need to look more closely to see not just "if" but
> "how" it is faster.

I just tested the performance difference before/after reverting this
particular commit. There is no measurable difference on my system.
So, what I saw was probably a result of multiple commits I cramped
together during testing.

In any case, optimizing mapconcat should not heart.

Best,
Ihor