[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ELPA submission: python-import

From: Augusto Stoffel
Subject: Re: ELPA submission: python-import
Date: Sat, 30 Jul 2022 10:56:22 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

On Fri, 29 Jul 2022 at 12:25, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>> I suppose two things speaking against it:
>> - The package depends on two external tools (isort and pyflakes) that
>>   are popular but neither built-in nor de facto standards.
>> - Sometimes the heuristics used there can be wrong (e.g. if relative
>>   imports (IMHO usually a bad idea anyway) are used).  I haven't used
>>   the package enough to judge how much of a problem this is.
> FWIW, I don't find those to be good reasons to keep the code separate.
> It's quite common for some parts of the functionality of a major modes
> to be less thorough (e.g. depend on the presence of some unusual tool,
> or depend on specific conventions, ...): it's not ideal, but it's better
> than nothing, and also makes it "obvious" where to improve the code.
> IOW it can encourage further improvements.

Sounds good then.  I'll develop and test the code a bit more locally for
a few weeks and then submit a patch.

In the meanwhile I'll keep updating the git repo linked in my previous
message.  Feedback from anyone interested in checking it out is welcome.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]