[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] * vc-git.el (vc-git-log-edit-mode): Font lock long summary l

From: Sean Whitton
Subject: Re: [PATCH] * vc-git.el (vc-git-log-edit-mode): Font lock long summary lines.
Date: Sun, 04 Sep 2022 10:27:09 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)


On Sun 04 Sep 2022 at 12:50PM +02, Lars Ingebrigtsen wrote:

> Sean Whitton <spwhitton@spwhitton.name> writes:
>> I'd like to install this patch to highlight long summary lines when composing
>> git commit messages.  Comments welcome.
> What constitutes a too-long summary line varies by project, so I don't
> think doing this by default would be appreciated.  But it would be a
> user option.

Ah okay, I don't recall having myself seen anything written down other
than 50/68, though I know plenty of projects don't care about it at all.

I'm thinking two defcustoms, then:

    vc-git-summary-target-length defaults to nil,
         I'll make emacs.git's .dir-locals.el set it to 50

    vc-git-summary-max-length defaults to 68.

(The name of the latter is based on `git-commit-summary-max-length' from
git-commit.el on my system, which I believe is pulled in by Magit.)

Sean Whitton

reply via email to

[Prev in Thread] Current Thread [Next in Thread]