[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Font lock long Git commit summary lines

From: Sean Whitton
Subject: Re: [PATCH v2] Font lock long Git commit summary lines
Date: Mon, 05 Sep 2022 11:14:27 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)


I've applied most of this, thank you.  Rather than replace 'target',
which I think is right, I renamed the two faces.  What we have are two
warnings, no errors.

On Mon 05 Sep 2022 at 03:07PM +03, Eli Zaretskii wrote:

>> +(defun vc-git--log-edit-summary-check (limit)
>> +  (and (re-search-forward "^Summary: " limit t)
>> +       (when-let ((regex
>> +                   (cond ((and vc-git-log-edit-summary-max
>> +                               vc-git-log-edit-summary-target)
> Should this test using numberp?
>> +                         (vc-git-log-edit-summary-max
>> +                          (format ".\\{,%d\\}\\(?2:.*\\)"
>> +                                  vc-git-log-edit-summary-max))
>> +                         (vc-git-log-edit-summary-target
>> +                          (format ".\\{,%d\\}\\(.*\\)"
>> +                                  vc-git-log-edit-summary-target)))))
> Likewise here.

I put calls to natnump in, but I'm not sure about it.  Is it really most
useful to silently fail to highlight the characters if somehow something
other than a number has ended up in the variables?  I'm new to working
with font lock so would be grateful for more input.

Sean Whitton

reply via email to

[Prev in Thread] Current Thread [Next in Thread]