emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Tree-sitter integration in python.el


From: Yuan Fu
Subject: Re: Tree-sitter integration in python.el
Date: Wed, 5 Oct 2022 19:56:06 -0700


> On Oct 3, 2022, at 3:47 PM, Matthias Meulien <orontee@gmail.com> wrote:
> 
> Yuan Fu <casouri@gmail.com> writes:
> 
>>> On Oct 3, 2022, at 3:19 PM, Matthias Meulien <orontee@gmail.com> wrote:
> 
>>> (...)  At first sight, moving commands and imenu seems to work as
>>> expected.  Fontification too.
>> 
>> I didn’t modify and move commands. There are a lot of them and I don’t
>> know if tree-sitter would bring any improvement. Imenu and font-lock
>> are indeed powered by tree-sitter.
> 
> Ok.  Thanks for clarifying.
> 
>>> I saw small differences between buffers fontified with
>>> `python-use-tree-sitter' equal to nil and t.  Attached is a screenshot
>>> where one can see two such differences (the third tall buffer shows the
>>> output of "tree-sitter highlight"):
>>> 
>>> - line 284: The self attribute
>> 
>> Why is the _url attribute highlighted? Other attributes don’t seem to
>> be highlighted.
> 
> I guess it's because it is on the left hand side of an assignment.
> 

I’ve fixed fontification discrepancies you found and pushed the change.

Yuan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]