Re: [PATCH] Add user content APIs for WebKit Xwidgets

[Po Lu]

Qiantan Hong <qthong@stanford.edu> writes:

> Yes I’m aware. I was fixing them one by one.

Thanks.

> It seems that existing code is connecting signal without adding the marking
> code, guess that should be fixed too...

Where?  Existing code should not connect signals to anything other than
`widget_osr' which is destroyed upon the xwidget being killed, a
prerequisite for being marked by GC.

> Those two problems above, I don’t have any existing code to imitate, so it
> would take a while to learn the codebase for me to be able to fix them.
> I’m also not sure if I should just make my part conforming or also fix all 
> existing code.
> Is it acceptable that I submit a patch (with other problems fixed) first,
> and work on fixing these two classes of problems later?

I'd rather not install code with known memory management issues,
especially not this close to the Emacs 29 release.