[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Stylistic changes to tree-sitter code
From: |
Yuan Fu |
Subject: |
Re: Stylistic changes to tree-sitter code |
Date: |
Thu, 27 Oct 2022 21:14:48 -0700 |
> On Oct 27, 2022, at 5:41 PM, Po Lu via Emacs development discussions.
> <emacs-devel@gnu.org> wrote:
>
> Robert Pluim <rpluim@gmail.com> writes:
>
>>>>>>> On Thu, 27 Oct 2022 21:33:10 +0800, Po Lu via "Emacs development
>>>>>>> discussions." <emacs-devel@gnu.org> said:
>>
>>
>> Po Lu> Unfortunately, I don't have tree-sitter installed, so would someone
>> Po Lu> please do a smoke test on the changes before I install them?
>>
>> I have it installed, but I donʼt use it yet, so all I can offer is a
>> compile test:
>>
>> CC treesit.o
>> treesit.c: In function ‘treesit_find_override_name’:
>> treesit.c:467:41: error: ‘list’ undeclared (first use in this function); did
>> you mean ‘listn’?
>> 467 | *name = Fnth (make_fixnum (1), XCAR (list));
>> | ^~~~
>> | listn
>> treesit.c:467:41: note: each undeclared identifier is reported only once for
>> each function it appears in
>> treesit.c:476:57: error: expected ‘;’ before ‘return’
>> 476 | CHECK_LIST_END (tem, Vtreesit_load_name_override_list)
>> | ^
>> | ;
>> 477 |
>> 478 | return false;
>> | ~~~~~~
>> treesit.c: In function ‘treesit_load_language’:
>> treesit.c:555:15: error: redeclaration of ‘tail’ with no linkage
>> 555 | Lisp_Object tail;
>> | ^~~~
>> treesit.c:539:15: note: previous declaration of ‘tail’ was here
>> 539 | Lisp_Object tail;
>> | ^~~~
>> treesit.c: In function ‘treesit_find_override_name’:
>> treesit.c:479:1: warning: control reaches end of non-void function
>> [-Wreturn-type]
>> 479 | }
>> | ^
>> make[2]: *** [Makefile:424: treesit.o] Error 1
>>
>> Robert
>
> Thanks. What about this patch?
Thanks for your work! I don’t have opinions on stylistic changes :-)
Yuan
- Stylistic changes to tree-sitter code, Po Lu, 2022/10/27
- Re: Stylistic changes to tree-sitter code, Robert Pluim, 2022/10/27
- Re: Stylistic changes to tree-sitter code, Po Lu, 2022/10/27
- Re: Stylistic changes to tree-sitter code,
Yuan Fu <=
- Re: Stylistic changes to tree-sitter code, Robert Pluim, 2022/10/28
- Re: Stylistic changes to tree-sitter code, Po Lu, 2022/10/28
- Re: Stylistic changes to tree-sitter code, Po Lu, 2022/10/28
- Re: Stylistic changes to tree-sitter code, Yuan Fu, 2022/10/29
- Re: Stylistic changes to tree-sitter code, Po Lu, 2022/10/29
- Re: Stylistic changes to tree-sitter code, Eli Zaretskii, 2022/10/29
- Re: Stylistic changes to tree-sitter code, Po Lu, 2022/10/29
- Re: Stylistic changes to tree-sitter code, Eli Zaretskii, 2022/10/29
- Re: Stylistic changes to tree-sitter code, Po Lu, 2022/10/29
- Re: Stylistic changes to tree-sitter code, Eli Zaretskii, 2022/10/29