[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: feature/tree-sitter 88d54756d4 2/2: Check for outdated tree-sitter n
From: |
Yuan Fu |
Subject: |
Re: feature/tree-sitter 88d54756d4 2/2: Check for outdated tree-sitter node when printing |
Date: |
Thu, 3 Nov 2022 02:33:49 -0700 |
> On Nov 3, 2022, at 1:09 AM, Po Lu <luangruo@yahoo.com> wrote:
>
> Yuan Fu <casouri@gmail.com> writes:
>
>> Cool, thanks. I’ll fix them.
>
> Thanks.
>
>> Ah yes, sorry. I though you are going to change your patch and forgot
>> to follow up. Everything indeed works, except for the following
>>
>> - return Fmapconcat (intern_c_string ("treesit-pattern-expand"),
>> - query, build_pure_c_string (" "));
>> + return Fmapconcat (Qtreesit_pattern_expand,
>>
>> Which breaks a test. Why remove the space? Tree-sitter probably can
>> parse it fine without the spaces, but the result is also viewed by
>> users in some cases, where spaces are much appreciated.
>
> That was a typo; I just tried to get rid of the extra call to
> intern_c_string.
>
> So if you're fine with the patch (once I fix the typos), I'll install
> it. Is that okay?
Yeah, feel free to do so, and thanks for your work again.
Yuan