[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Understanding end-of-defun

From: Yuan Fu
Subject: Re: Understanding end-of-defun
Date: Thu, 10 Nov 2022 15:10:07 -0800

> On Nov 10, 2022, at 2:49 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>>> I haven't had a chance to try it out, but it looks good to me, tho
>>> `beginning-of-defun-raw` doesn't mention anything about its return value
>>> in the its docstring, so we may want to tweak that docstring (and
>>> review its code to make sure that it indeed returns the value we need
>>> in all cases, tho I suspect you've done so already).
>> (Sorry for the delay) Yes, it returns nil in all cases. Pretty sure that’s
>> the intent from the very beginning (looking at git logs). How about
>> this patch?
> LGTM, thank you!

I pushed this to feature/tree-sitter. I looked at tests for end-of-defun, the 
only one I found runs fine. I could add a test for this change but I don’t know 
what we’ll test for.

> PS: I'm very happy to work with you: I just babble about and you
>    go and do the grunt work.  Half kidding, obviously, but really,
>    I appreciate it, thank you.

Oh thank you! That made my day :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]