emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Plug treesit.el into other emacs constructs


From: Yuan Fu
Subject: Re: Plug treesit.el into other emacs constructs
Date: Sat, 24 Dec 2022 00:44:12 -0800


> On Dec 23, 2022, at 11:00 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Theodor Thornhill <theo@thornhill.no>
>> Cc: Yuan Fu <casouri@gmail.com>, emacs-devel@gnu.org, eliz@gnu.org
>> Date: Thu, 15 Dec 2022 21:57:31 +0100
>> 
>> Theodor Thornhill <theo@thornhill.no> writes:
>> 
>>> Theodor Thornhill <theo@thornhill.no> writes:
>>> 
>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>>> 
>>>>>> If this code is plugged into transpose-sexps we get this nice behavior:
>>>>> 
>>>>> It's a bit different from what SMIE would do, but there's a lot of
>>>>> overlap and when it's different it's arguably better, so sounds good
>>>>> to me.
>>>>> 
>>>> 
>>>> Great!
>>>> 
>>>>>> Now forward/backward-sexp can actually work a little differently, as you
>>>>>> suggest, or we can let it use the same "move over siblings"-semantic.
>>>>>> In that case we don't even need the treesit-sexp-type-regexp variables to
>>>>>> control this, I think.
>>>>>> 
>>>>>> What do you think?
>>>>> 
>>>>> I'm not sufficiently familiar with the tree-sitter tree to foresee
>>>>> precisely how it would affect `forward/backward-sexp`, but I think you
>>>>> have a good enough understanding to make a good judgment at this
>>>>> point :-)
>>>> 
>>>> Great. I'll prepare a patch for this behavior, and we can discuss the
>>>> forward-* commands after that.
>>>> 
>>> 
>>> What do you think about this?  Feel free to try it and let me know if
>>> something is completely wrong :-)
>> 
>> Now you can use 'arg' as well.
> 
> Stefan, Yuan: any comments or objections to installing this on master?

This is the same as the patch in bug#60128, right? I don’t have much to comment 
about it. It looks pretty nice to me :-)

Yuan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]