emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] em-cmpl: fix completion of command paths


From: Stefan Monnier
Subject: Re: [PATCH] em-cmpl: fix completion of command paths
Date: Fri, 27 Jan 2023 19:12:11 -0500
User-agent: Gnus/5.13 (Gnus v5.13)

>> Eli, what do you think?
> Yes, this is okay for emacs-29.

Thanks, I'll push it soon.

>> > +    ;; Do not use `completion-table-dynamic' when completing a command 
>> > path
>> > +    ;; (absolute or relative): doing so assumes that the subpath in the 
>> > input
>> > +    ;; string is always a command, and appends a space character, which is
>> > +    ;; incorrect (i.e. "/usr/bi" should yield "/usr/bin/" after 
>> > completion,
>> > +    ;; not "/usr/bin/ ").
>
> Please use "file name", not "path", when referring to file or
> directory names.  If you need to make it clear you are talking about
> absolute file name, use "absolute file name" or "file name with
> leading directories".  GNU coding standards frown on using "path" for
> anything but PATH-style lists of directories.  (Yes, I know that most
> of this text came from a comment in the original code.)

Thanks for catching this.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]