emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New unwind-protect byte-compiler warning


From: Gregory Heytings
Subject: Re: New unwind-protect byte-compiler warning
Date: Tue, 04 Apr 2023 12:32:41 +0000



This one:

   In mouse-wheel-global-text-scale:
   mwheel.el:450:6: Warning: ‘unwind-protect’ without unwind forms

is because weʼre protecting against errors from `global-text-scale-adjust', but unlike `text-scale-{in,de}crease', that doesnʼt signal an error when you reach the scale limit.

Juri, we can add an unwind form of `t', or switch it to `condition-case', whichever you prefer (Iʼm assuming perhaps pessimistically that `global-text-scale-adjust' might signal in future).


The byte-compiler warning is correct, this is a copy-paste error in e0488f89d1, the unwind-protect is unnecessary and can be removed.
reply via email to

[Prev in Thread] Current Thread [Next in Thread]