emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 361c5fc2d8e 3/3: Support more predicates in tree-sitter searc


From: Po Lu
Subject: Re: master 361c5fc2d8e 3/3: Support more predicates in tree-sitter search functions
Date: Fri, 14 Apr 2023 12:31:49 +0800
User-agent: Gnus/5.13 (Gnus v5.13)

Yuan Fu <casouri@gmail.com> writes:

> Ok, I can add a recursion limit check.

Great, thanks.

> Is it really necessary? IMHO having the braces is clearer when the statement 
> has more than one line.

We prefer to avoid redundant braces, yes.

> I like to always initialize variables.

OK, but this wastes cycles.

> Either way should be fine. I’ve been using the current style
> throughout treesit.c.

The compiler cannot perform automatic register allocation on
`signal_data' your way.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]