Re: master 361c5fc2d8e 3/3: Support more predicates in tree-sitter search functions

[Yuan Fu]

> On Apr 13, 2023, at 9:31 PM, Po Lu <luangruo@yahoo.com> wrote:
> 
> Yuan Fu <casouri@gmail.com> writes:
> 
>> Ok, I can add a recursion limit check.
> 
> Great, thanks.
> 
>> Is it really necessary? IMHO having the braces is clearer when the statement 
>> has more than one line.
> 
> We prefer to avoid redundant braces, yes.

If you insist, ok.

>> I like to always initialize variables.
> 
> OK, but this wastes cycles.
> 
>> Either way should be fine. I’ve been using the current style
>> throughout treesit.c.
> 
> The compiler cannot perform automatic register allocation on
> `signal_data' your way.

While you are absolutely right, the performance benefit surely would be 
negligible, no?

Yuan