emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Info-mode patch


From: Eli Zaretskii
Subject: Re: Info-mode patch
Date: Mon, 03 Jul 2023 21:57:59 +0300

> From: Juri Linkov <juri@linkov.net>
> Cc: Arthur Miller <arthur.miller@live.com>,  emacs-devel@gnu.org
> Date: Mon, 03 Jul 2023 21:40:10 +0300
> 
> >> >> >> It seems you found a bug in 'key-valid-p'!
> >> >> >> And indeed it returns nil:
> >> >> >>
> >> >> >>   (key-valid-p "<tool-bar> <C-Back in history>")
> >> >> >
> >> >> > Why is it a bug?  "<tool-bar> <C-Back in history>" has no meaning,
> >> >> > since it isn't a mouse event.
> >> >>
> >> >> Is "remap" a mouse event?
> >> >
> >> > Why is "remap" relevant to the issue at hand?
> >>
> >> I converted from "old idiom" in info.el to new defvar-keymap. When
> >> seeing "remap" (a dummy event) works, I just expected defvar-keymap was
> >> done the way that it is possible to use all keys, fake-kyes, events,
> >> and whatnot the same way. Similar as I expected 'frame to have same
> >> meaning everywhere for the uniformity.
> >>
> >> Would look more tidy if it was possible to keep all key definitions in
> >> the same place as in the old code.
> >
> > Do you mean that we had a binding like [tool-bar C-Back\ in\ history]
> > somewhere?
> 
> This symbol is generated automatically by 'easy-menu-define'
> from the menu item "Back in History" with spaces inside.

key-valid-p invalidates keys that have embedded whitespace, so we need
to decide whether we want to add that or modify easy-menu-define to
produce more reasonable symbols.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]