|
From: | Herman , Géza |
Subject: | Re: I created a faster JSON parser |
Date: | Mon, 11 Mar 2024 10:34:36 +0100 |
Christopher Wellons <wellons@nullprogram.com> writes:
It's been running for an hour, the tester didn't find any problems yet.Except for an overflow assigning huge floats to the dummy Lisp_Objectvalue — which is a problem with the test, not the parser — thisstripped down version looks robust to me, too. Solid work! I have nofurther feedback or commentary.
Cool! Out of curiosity, how did you find the overflow problem? Did you just notice it, or did the fuzzer/sanitizer find it?
I made a few tweaks to harden the test, which did not change the results:
Thanks for the work! I think that we can say then that the new parser works OK, it's unlikely that it has any serious problem.
it incorrectly optimizes around setjmp in do_test()If a program modifies a variable after the first setjmp return andthen accesses it after the second setjmp return, it must be volatile-qualified.
Good to know, thanks for the info!
[Prev in Thread] | Current Thread | [Next in Thread] |