Re: master 5a125fb5a97 1/2: Update to Org 9.7.3

[Ihor Radchenko]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Tue, 11 Jun 2024 15:23:29 +0300, Eli Zaretskii <eliz@gnu.org> said:
>     >> > Why does it want to read a file from my home directory as part of
>     >> > building Emacs?  That shouldn't happen.
>     >> 
>     >> Agree. But I am unable to reproduce.
>     >> Could you please provide more information?
>
> Removing "~/.emacs.d/.org-id-locations" is enough for me:
>
>   org-id-locations-load()
>   (if org-id-locations nil (org-id-locations-load))
>   org-id-find-id-file("org-manual-get-export-props-customizations")
>   org-babel-ref-goto-headline-id("org-manual-get-export-props-customizations")
>   org-babel-expand-noweb-references(...)

This reveals a serious problem. Org indeed must not examine id db on the
build machine.

I installed the fix on Org side:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=13fdbf73f
However, this fix will only affect builds in Org git repo.

Please install the attached equivalent fix for Emacs makefiles.

>From 5fefaad5b1c3ca4d10d3208e782596d79de8ca18 Mon Sep 17 00:00:00 2001
Message-ID: 
<5fefaad5b1c3ca4d10d3208e782596d79de8ca18.1718358372.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Fri, 14 Jun 2024 11:45:00 +0200
Subject: [PATCH] Do not search local id: db when building Org mode manual

* doc/misc/Makefile.in ($(1:.org=.texi)): Disable global id: database
when building Org manual.  This prevents the build from reaching out to
local ID db on the build machine.

Reported-by: Eli Zaretskii <eliz@gnu.org>
Link: 868qzd9hjg.fsf@gnu.org/">https://yhetil.org/emacs-devel/868qzd9hjg.fsf@gnu.org/
---
 doc/misc/Makefile.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/misc/Makefile.in b/doc/misc/Makefile.in
index b26d3525a22..f1d03ff4b39 100644
--- a/doc/misc/Makefile.in
+++ b/doc/misc/Makefile.in
@@ -246,11 +246,14 @@ emacs =
 # release tarfile along with the others.
 # Work in srcdir (and use abs_top_builddir) so that +setupfile and
 # things like org-setup's "version" macro work.  Sigh.
+# Also, disable `org-id-track-globally' to make sure that link/target
+# resolution never ever tries to reach local user id: database.
 define org_template
  $(1:.org=.texi): $(1) ${top_srcdir}/lisp/org/ox-texinfo.el
        $${AM_V_GEN}cd "$${srcdir}" && $${emacs} -l ox-texinfo \
          --eval '(setq gc-cons-threshold 50000000)' \
          --eval '(setq org-confirm-babel-evaluate nil)' \
+         --eval '(setq org-id-track-globally nil)' \
          -f org-texinfo-export-to-texinfo-batch $$(notdir $$<) $$(notdir $$@)
 endef
 
-- 
2.45.1

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>