Re: master 5f9b5803bea: Fix zooming images in SHR

[Eli Zaretskii]

> Date: Sun, 23 Jun 2024 15:13:36 -0700
> Cc: jm@pub.pink, emacs-devel@gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
> 
> On 6/23/2024 12:23 PM, Eli Zaretskii wrote:
> > Thanks, but the test fails for me on MS-Windows:
> > 
> >    Test shr-test/zoom-image condition:
> >        Info: image with alt=nil
> >        (error "timed out waiting for condition")
> >       FAILED  3/4  shr-test/zoom-image (5.053704 sec) at 
> > lisp/net/shr-tests.el:136
> > 
> > (The other test failed as well, but I fixed it.)
> > 
> > Frankly, I have no idea why it fails, because I only vaguely
> > understand the idea of the test.  Feel free to ask questions or
> > suggests what to test.
> 
> Could you try commenting out the "(inhibit-message t)" line in the test 
> and rerunning it? My guess is that on MS-Windows, something goes wrong 
> when inserting the image into the buffer, so 'shr-zoom-image' can't find 
> the image. (For reasons I'm not sure about, when 'shr-zoom-image' fails 
> to find an image, it just prints a message instead of signaling an error.)

I don't see any additional info when I delete that line, but maybe I'm
missing something.  Here:

     passed  1/4  rendering (0.020026 sec)
     passed  2/4  shr-srcset (0.000348 sec)
  Test shr-test/zoom-image backtrace:
    signal(error ("timed out waiting for condition"))
    error("timed out waiting for condition")
    (progn (error message))
    (if (> (float-time (time-since start)) shr-test--max-wait-time) (pro
    (while (not (funcall predicate)) (if (> (float-time (time-since star
    (let ((start (current-time)) (message (or message "timed out waiting
    shr-test-wait-for(#f(lambda () [(put-image-calls 0)] (= put-image-ca
    (let ((dom (libxml-parse-html-region (point-min) (point-max)))) (era
    (let ((shr-image-animate nil)) (let ((dom (libxml-parse-html-region
    (let ((shr-use-fonts nil)) (let ((shr-image-animate nil)) (let ((dom
    (let ((shr-width 80)) (let ((shr-use-fonts nil)) (let ((shr-image-an
    (let ((shr-put-image-function #'(lambda (&rest args) (setq put-image
    (let ((put-image-calls 0)) (let ((shr-put-image-function #'(lambda (
    (progn (fset 'url-queue-retrieve vnew) (let ((put-image-calls 0)) (l
    (unwind-protect (progn (fset 'url-queue-retrieve vnew) (let ((put-im
    (let* ((vnew #'(lambda (&rest args) (apply #'run-at-time 0 nil #'url
    (progn (fset 'display-graphic-p #'always) (let* ((vnew #'(lambda (&r
    (unwind-protect (progn (fset 'display-graphic-p #'always) (let* ((vn
    (let* ((old (symbol-function 'display-graphic-p))) (unwind-protect (
    (let ((ert--infos (cons (cons "Info: " (format "image with alt=%S" a
    (progn (let ((ert--infos (cons (cons "Info: " (format "image with al
    (unwind-protect (progn (let ((ert--infos (cons (cons "Info: " (forma
    (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
    (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
    (let ((alt (car tail))) (let ((temp-buffer (generate-new-buffer " *t
    (while tail (let ((alt (car tail))) (let ((temp-buffer (generate-new
    (let ((tail '(nil "" "nothing to see here"))) (while tail (let ((alt
    (let ((image (expand-file-name "data/image/blank-100x200.png" (geten
    #f(lambda () [t] (let ((value-60 (gensym "ert-form-evaluation-aborte
    #f(compiled-function () #<bytecode -0x118f7354823f30c9>)()
    handler-bind-1(#f(compiled-function () #<bytecode -0x118f7354823f30c
    ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
    ert-run-test(#s(ert-test :name shr-test/zoom-image :documentation "T
    ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
    ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
    ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
    ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
    eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
    command-line-1(("-L" ";." "-l" "ert" "--eval" "(setq treesit-extra-l
    command-line()
    normal-top-level()
  Test shr-test/zoom-image condition:
      Info: image with alt=nil
      (error "timed out waiting for condition")
     FAILED  3/4  shr-test/zoom-image (5.186791 sec) at 
lisp/net/shr-tests.el:136
     passed  4/4  use-cookies (0.035256 sec)