emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MPS: dangling markers


From: Gerd Möllmann
Subject: Re: MPS: dangling markers
Date: Sun, 30 Jun 2024 14:28:18 +0200
User-agent: Gnus/5.13 (Gnus v5.13)

Ihor Radchenko <yantar92@posteo.net> writes:

> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>
>> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>>
>>> I think I have an idea: What if igc_add_marker records in Lisp_Marker at
>>> which index in the weak vector it stored the marker? That would make
>>> igc_remove_marker O(1).
>>
>> Pushed that to scratch/igc.
>>
>> Ihor, could please measure again?
>
> As expected, igc_remove_marker disappeared. igc_add_marker is still there.
>
>     33.12%  emacs            emacs                                          
> [.] igc_add_marker

Thanks, Ihor, that looks promising. I've now also pushed a quick and
dirty add_marker in O(1), that's why I reverted. to get that on top.
Works for me...

A comparison of how it feels compared to master would also be interesting.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]