[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r106712: * progmodes/cfengine.el:

From: Ted Zlatanov
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r106712: * progmodes/cfengine.el: Add CFEngine 3.x syntax highlighting and support.
Date: Fri, 23 Dec 2011 04:17:53 -0500
User-agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (gnu/linux)

On Thu, 22 Dec 2011 19:27:06 -0500 Stefan Monnier <address@hidden> wrote: 

SM> Ted, please be careful with your commit messages:
SM> 1- the bzr commit message should be the same as the one is the ChangeLog
SM>    (so the ChangeLog will ultimately be produced from the Bzr commit
SM>    messages).
SM> 2- the style of your ChangeLog entries need to follow the Gnu
SM>    coding standard.  See the megabytes of examples in the Emacs source
SM>    tree, and http://www.gnu.org/prep/standards/html_node/Change-Logs.html.

Sorry, I was in a hurry and didn't do it properly.  I'll do better next
time.  Can I edit the commit message after the push?  Or did you already
do it?


>> * progmodes/cfengine.el: Add CFEngine 3.x syntax highlighting and support.

SM> Not a fair enough summary since it doesn't talk about the change of
SM> cfengine-mode (and because there already was cfengine-3 font-lock
SM> support, so this support is definitely not added by the commit, it's
SM> just slightly improved).  And you need to add a copy of the ChangeLog
SM> text (use C-c C-a from the *VC-Log* buffer to do that for you).

>> +    * progmodes/cfengine.el: Add Version.
>> +
>> +    Add CFEngine 3.x syntax highlighting and support with
>> +    `cfengine3-mode', and rename the old `cfengine-mode' to
>> +    `cfengine2-mode'.  Make `cfengine-mode' an automatic content-based
>> +    switcher between `cfengine3-mode' and `cfengine2-mode' by aliasing
>> +    it to `cfengine-auto-mode'.  Rename variables specific to
>> +    `cfengine2-mode' from cfengine-* to cfengine2-*.  Change the
>> +    modeline indicator to "CFE2" and "CFE3" depending on the mode, to
>> +    save space. Mark `cfengine-mode-abbrevs' as obsolete.

SM> Wrong format.  For example, the last sentence should be replaced by:

SM>     (cfengine-mode-abbrevs): Mark obsolete.

SM> Also the empty line between "* progmodes/cfengine.el: Add Version." and
SM> the rest makes it seem like the two are separate and hence makes it
SM> unclear which file the second part refers to.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]