[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] /srv/bzr/emacs/trunk r106712: * progmodes/cfengine.el:
Re: [Emacs-diffs] /srv/bzr/emacs/trunk r106712: * progmodes/cfengine.el: Add CFEngine 3.x syntax highlighting and support.
Wed, 28 Dec 2011 19:22:58 -0500
Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (gnu/linux)
On Tue, 27 Dec 2011 12:10:06 -0500 Ted Zlatanov <address@hidden> wrote:
TZ> On Fri, 23 Dec 2011 18:47:58 -0500 Stefan Monnier <address@hidden> wrote:
>>> Sorry, I was in a hurry and didn't do it properly. I'll do better next
>>> time. Can I edit the commit message after the push? Or did you already
>>> do it?
SM> No, you can't edit the commit message. But you can edit the ChangeLog
TZ> OK, here's a revised version. Do you want me to also list all the
TZ> variables I renamed? I hope it's OK.
TZ> * progmodes/cfengine.el: Add Version. Improve CFEngine 3.x syntax
TZ> highlighting and support. Rename variables specific to
TZ> `cfengine2-mode' from cfengine-* to cfengine2-*.
TZ> (cfengine3-mode): Change the modeline indicator to "CFE3".
TZ> (cfengine2-mode): Rename from `cfengine-mode'. Change the
TZ> modeline indicator to "CFE2".
TZ> (cfengine-mode): Defalias to `cfengine-auto-mode'.
TZ> (cfengine-mode-abbrevs): Mark obsolete.
TZ> Again, sorry for the bad message, it was a bad oversight on my part.
In this context I was thinking that maybe it makes sense to allow
committers to revise a commit message. I don't mean the original
message, but rather some format like
"(revise 106712) new-commit-message-line-1
so automated tools can build the ChangeLog from the commit messages,
even if the original commit messages are faulty. Otherwise we're stuck
with bad immutable commit messages if any committer makes a mistake like