[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/gnugo 5b51e4f 129/357: [gnugo int] Decruft: Consolidate
From: |
Stefan Monnier |
Subject: |
[elpa] externals/gnugo 5b51e4f 129/357: [gnugo int] Decruft: Consolidate "breathe in" loops. |
Date: |
Sun, 29 Nov 2020 14:51:05 -0500 (EST) |
branch: externals/gnugo
commit 5b51e4fc73a222fc03c665860f8f4ed5ea5702c8
Author: Thien-Thi Nguyen <ttn@gnu.org>
Commit: Thien-Thi Nguyen <ttn@gnu.org>
[gnugo int] Decruft: Consolidate "breathe in" loops.
* packages/gnugo/gnugo.el (gnugo-frolic-in-the-leaves):
...here, as :monkey no longer confers a priori move-number info.
---
gnugo.el | 27 +++++----------------------
1 file changed, 5 insertions(+), 22 deletions(-)
diff --git a/gnugo.el b/gnugo.el
index c27ac61..a953a5c 100644
--- a/gnugo.el
+++ b/gnugo.el
@@ -770,19 +770,7 @@ are dimmed. The buffer is in View minor mode."
(fsi (fmt &rest args)
(insert (apply 'format fmt args))))
;; breathe in
- (let ((monkey-on-main-line (zerop bidx))
- fixup)
- ;; monkey knows a lot
- (loop with acc
- for node in (aref monkey 0)
- do (puthash node bidx seen)
- if (gnugo--move-prop node)
- do (push node acc)
- finally do (progn
- (unless monkey-on-main-line
- (setq fixup (apply 'vector acc)))
- (aset eert bidx acc)))
- ;; but monkey does not know everything
+ (let ()
(loop
for bx below width
do (loop
@@ -794,14 +782,6 @@ are dimmed. The buffer is in View minor mode."
((link (other)
(push other (gethash node soil))))
(let ((move-num (gethash node mnum)))
- (when (< bx fork)
- (assert (and (not monkey-on-main-line)
- (= fork bidx)))
- (loop for old in ls
- while (< bx (on old))
- do (puthash old bx seen))
- (when (< move-num (length fixup))
- (link (aref fixup move-num))))
;; ugh, wasteful
(when (setq bef (copy-sequence (aref eert fork)))
(setcdr (nthcdr (1- move-num) bef)
@@ -812,7 +792,10 @@ are dimmed. The buffer is in View minor mode."
(puthash node bx seen)
(when (gnugo--move-prop node)
(push node acc)))
- until fork)))
+ until fork
+ finally do (unless fork
+ (assert (zerop bx))
+ (aset eert bx acc)))))
;; breathe out
(switch-to-buffer buf)
(when view-mode
- [elpa] externals/gnugo e036fed 096/357: [gnugo] Fix bug: On load, follow mainline through subtrees., (continued)
- [elpa] externals/gnugo e036fed 096/357: [gnugo] Fix bug: On load, follow mainline through subtrees., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo eaaa7c8 102/357: [gnugo int] Invert gametree IR to hang by the leaves., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo ed11a74 101/357: [gnugo int] Embrace (NODE[...] [SUBTREE...]) IR, for now., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo b7843bf 103/357: [gnugo maint] Move hi-lock hint from NEWS to HACKING; nfc., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo ae888ba 105/357: [gnugo] Add command ‘gnugo-oops’ and keybinding., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 2c5e356 107/357: [gnugo maint] Add some debugging aids to HACKING; nfc., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo a708759 110/357: [gnugo int] Use ‘cl-labels’ less., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo a35f657 115/357: [gnugo] Support SGF[4] parsing from string data., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 3d8db48 119/357: [gnugo] Declare dependency on ‘ascii-art-to-unicode’., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 4b866c7 127/357: [gnugo int] Avoid lower move-num candidates in déjà-vu search., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 5b51e4f 129/357: [gnugo int] Decruft: Consolidate "breathe in" loops.,
Stefan Monnier <=
- [elpa] externals/gnugo fda0ca5 130/357: [gnugo int] Move precise fanout computation to "breathe in"., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo cbf99df 131/357: [gnugo int] Insert frolic xrep starting w/ the leaves., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 5c87b11 141/357: [gnugo frolic int] Use ‘move-to-column’ more., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo d62412f 144/357: [gnugo int] Add abstraction: gnugo--move-to-bcol, Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 4680536 143/357: [gnugo int] Fix bug: Unbreak SGF file output., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 806a2f2 133/357: [gnugo] Add some navigation commands for GNUGO Frolic mode., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo c6795aa 140/357: [gnugo frolic int] Assign ‘pop’ rv to avoid byte-compiler warning., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 13c8f82 149/357: [gnugo frolic] Doc fix., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo de40b22 152/357: [gnugo int] Move vectorization into ‘gnugo--set-tree-ends’., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo e8833a9 161/357: [gnugo int] Fix syntax error in ‘loop’ destructuring., Stefan Monnier, 2020/11/29