emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/gnugo e8833a9 161/357: [gnugo int] Fix syntax error in


From: Stefan Monnier
Subject: [elpa] externals/gnugo e8833a9 161/357: [gnugo int] Fix syntax error in ‘loop’ destructuring.
Date: Sun, 29 Nov 2020 14:51:12 -0500 (EST)

branch: externals/gnugo
commit e8833a956fd37c4f7e0411579a1e7c589b8e896d
Author: Thien-Thi Nguyen <ttn@gnu.org>
Commit: Thien-Thi Nguyen <ttn@gnu.org>

    [gnugo int] Fix syntax error in ‘loop’ destructuring.
    
    The destructuring is similar to but not identical to the
    facility provided by ‘defmacro’ (info "(cl) For Clauses").
    This was caught, btw, while trying to byte-compile w/
    ‘-*- lexical-binding: t -*-’ on the first line.
    
    * packages/gnugo/gnugo.el (gnugo-board-mode):
    Omit ‘&optional’ from ‘for’ clause variable destructuring form.
---
 gnugo.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnugo.el b/gnugo.el
index c225fc7..ab753f2 100644
--- a/gnugo.el
+++ b/gnugo.el
@@ -2209,7 +2209,7 @@ In this mode, keys do not self insert.
                            'gnugo-option-history))
         proc
         board-size user-color handicap komi minus-l infile)
-    (loop for (var default opt &optional rx)
+    (loop for (var default opt rx)
           in '((board-size      19 "--boardsize")
                (user-color "black" "--color" "\\(black\\|white\\)")
                (handicap         0 "--handicap")
@@ -2254,7 +2254,7 @@ In this mode, keys do not self insert.
       (gnugo-put :monkey (vector (aref (gnugo--tree-ends tree) 0) 0)))
     (gnugo--SZ! board-size)
     (loop with gb = (gnugo--blackp (gnugo-other user-color))
-          for (property value &optional mogrifyp) in
+          for (property value mogrifyp) in
           `((:SZ ,board-size)
             (:DT ,(format-time-string "%Y-%m-%d"))
             (:RU ,(if (string-match "--chinese-rules" args)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]