emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/gnugo f5fbba3 153/357: [gnugo int] Fix bug: Update loc


From: Stefan Monnier
Subject: [elpa] externals/gnugo f5fbba3 153/357: [gnugo int] Fix bug: Update local var ‘ends’ when branching.
Date: Sun, 29 Nov 2020 14:51:10 -0500 (EST)

branch: externals/gnugo
commit f5fbba306d7800acf750571ebb5f66286c308f85
Author: Thien-Thi Nguyen <ttn@gnu.org>
Commit: Thien-Thi Nguyen <ttn@gnu.org>

    [gnugo int] Fix bug: Update local var ‘ends’ when branching.
    
    Omission from 2014-04-05, "Expand gametree IR: MNUM, KIDS, ROOT".
    Note the unheeded hint: "hmm, probably unnecessary" -- d'oh!
    
    * packages/gnugo/gnugo.el (gnugo--set-tree-ends): Return the new ends.
    (gnugo-note): Update local var ‘ends’ w/ ‘gnugo--set-tree-ends’ rv.
---
 gnugo.el | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/gnugo.el b/gnugo.el
index bf63536..f9f9e99 100644
--- a/gnugo.el
+++ b/gnugo.el
@@ -261,8 +261,7 @@ See `gnugo-put'."
 
 (defsubst gnugo--set-tree-ends (tree ls)
   (aset tree 2 (apply 'vector ls))
-  ;; hmm, probably unnecessary
-  tree)
+  (gnugo--tree-ends tree))
 
 (defun gnugo-describe-internal-properties ()
   "Pretty-print `gnugo-state' properties in another buffer.
@@ -1175,11 +1174,11 @@ This fails if the monkey is on the current branch
            finally do
            (progn
              (unless (gnugo--no-regrets monkey ends)
-               (gnugo--set-tree-ends
-                tree (let ((ls (append ends nil)))
-                       ;; copy old to the right of new
-                       (push mem (nthcdr bidx ls))
-                       ls)))
+               (setq ends (gnugo--set-tree-ends
+                           tree (let ((ls (append ends nil)))
+                                  ;; copy old to the right of new
+                                  (push mem (nthcdr bidx ls))
+                                  ls))))
              (puthash fruit (1+ (gethash tip mnum)) mnum)
              (push fruit mem)
              (aset ends bidx mem)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]