[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/gnugo eb13b8e 180/357: [gnugo] Dropped command: ‘t’ (g
From: |
Stefan Monnier |
Subject: |
[elpa] externals/gnugo eb13b8e 180/357: [gnugo] Dropped command: ‘t’ (gnugo-toggle-dead-group) |
Date: |
Sun, 29 Nov 2020 14:51:16 -0500 (EST) |
branch: externals/gnugo
commit eb13b8eb59abce326520ec7c6fde56b3f9390eb5
Author: Thien-Thi Nguyen <ttn@gnu.org>
Commit: Thien-Thi Nguyen <ttn@gnu.org>
[gnugo] Dropped command: ‘t’ (gnugo-toggle-dead-group)
This was incomplete and not very useful.
* packages/gnugo/gnugo.el (gnugo-toggle-dead-group): Delete command.
(gnugo-board-mode-map): Don't bind ‘t’.
---
HACKING | 1 -
NEWS | 1 +
gnugo.el | 55 -------------------------------------------------------
3 files changed, 1 insertion(+), 56 deletions(-)
diff --git a/HACKING b/HACKING
index a62cff1..9110ef0 100644
--- a/HACKING
+++ b/HACKING
@@ -8,7 +8,6 @@ This file is both a guide for newcomers and a todo list for
oldstayers.
*** ‘-l FILENAME’ lossage
***** silently clobbers other options (PEBKAC, strictly speaking)
***** game tree incomplete (doing ‘C-x C-s’ immediately writes empty tree)
-*** [[file:gnugo.el::defun.gnugo-toggle-dead-group][gnugo-toggle-dead-group]]
only half-complete
*** no error-handling in SGF parsing
*** performance -- ‘compare-strings’ approach too clever/slow :-/
* ideas / wishlist
diff --git a/NEWS b/NEWS
index 4c39fde..fef55f7 100644
--- a/NEWS
+++ b/NEWS
@@ -14,6 +14,7 @@ NB: "RCS: X..Y " means that the particular release includes
- display "resign" as "resign" in move history (amazing!)
- avoid clobbering SGF property ‘EV’ on resignation
- follow main line in subtrees on read
+ - dropped command: ‘t’ (gnugo-toggle-dead-group)
- PASS for SZ <= 19 normalized to "" on read, written as ""
- ‘=’ also displays move number of the stone (if any) at that position
- new keybinding for ‘gnugo-undo-one-move’: M-u
diff --git a/gnugo.el b/gnugo.el
index 20474f1..2fa445f 100644
--- a/gnugo.el
+++ b/gnugo.el
@@ -1733,60 +1733,6 @@ Signal error if done out-of-turn or if game-over."
(gnugo-gate)
(gnugo-display-group-data "dragon_data" "*gnugo dragon data*"))
-(defun gnugo-toggle-dead-group ()
- "In a GNUGO Board buffer, during game-over, toggle a group as dead.
-The group is selected from current position (point). Signal error if
-not in game-over or if there is no group at that position.
-
-In the context of GNU Go, a group is called a \"dragon\" and may be
-composed of more than one \"worm\" (set of directly-connected stones).
-It is unclear to the gnugo.el author whether or not GNU Go supports
- - considering worms as groups in their own right; and
- - toggling group aliveness via GTP.
-Due to these uncertainties, this command is only half complete; the
-changes you may see in Emacs are not propagated to the gnugo subprocess.
-Thus, GTP commands like `final_score' may give unexpected results.
-
-If you are able to expose via GTP `change_dragon_status' in utils.c,
-you may consider modifying the `gnugo-toggle-dead-group' source code
-to enable full functionality."
- (interactive)
- (let ((game-over (or (gnugo-get :game-over)
- (user-error "Sorry, game still in play")))
- (group (or (get-text-property (point) 'group)
- (user-error "No stone at that position")))
- (now (current-time)))
- (gnugo-put :scoring-seed (logior (ash (logand (car now) 255) 16)
- (cadr now)))
- (let ((live (assq 'live game-over))
- (dead (assq 'dead game-over))
- bef now)
- (if (memq group live)
- (setq bef live now dead)
- (setq bef dead now live))
- (setcdr bef (delq group (cdr bef)))
- (setcdr now (cons group (cdr now)))
- ;; disabled permanently -- too wrong
- (when nil
- (cl-flet
- ((populate (group)
- (let ((color (caar group)))
- (dolist (stone (cdr group))
- (gnugo--play-stone color stone)))))
- (if (eq now live)
- (populate group)
- ;; drastic (and wrong -- clobbers capture info, etc)
- (gnugo-query "clear_board")
- (mapc #'populate (cdr live)))))
- ;; here is the desired interface (to be enabled Some Day)
- (when nil
- (gnugo-query "change_dragon_status %s %s"
- (cadr group) (if (eq now live)
- 'alive
- 'dead)))))
- (save-excursion
- (gnugo-refresh)))
-
(defun gnugo-estimate-score ()
"Display estimated score of a game of GNU Go.
Output includes number of stones on the board and number of stones
@@ -2521,7 +2467,6 @@ starting a new one. See `gnugo-board-mode' documentation
for more info."
("W" . gnugo-worm-data)
("d" . gnugo-dragon-stones)
("D" . gnugo-dragon-data)
- ("t" . gnugo-toggle-dead-group)
("g" . gnugo-toggle-grid)
("!" . gnugo-estimate-score)
(":" . gnugo-command)
- [elpa] externals/gnugo c885c9c 020/357: [gnugo int] Avoid variable FORMAT for ‘message’., (continued)
- [elpa] externals/gnugo c885c9c 020/357: [gnugo int] Avoid variable FORMAT for ‘message’., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo fce1fb0 077/357: [gnugo sgf] Fix bug: Output subtrees correctly., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 5ca7efb 099/357: [gnugo int] Remove redundant game-over condition check., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 7fee3b2 104/357: [gnugo] Move "1 or 2" calculation into ‘gnugo-magic-undo’., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo a86327a 108/357: [gnugo] Add command ‘gnugo-frolic-in-the-leaves’ and keybinding., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo f5fbba3 153/357: [gnugo int] Fix bug: Update local var ‘ends’ when branching., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo a4dcef8 150/357: [gnugo frolic int] Parameterize, centralize awakening., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 1b69add 160/357: [gnugo int] Decruft: Drop gametree IR element: KIDS, Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 891a97a 177/357: [gnugo int] Add abstraction: gnugo--decorate, Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 843cd96 163/357: [gnugo frolic int] Add abstraction: gnugo--sideways, Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo eb13b8e 180/357: [gnugo] Dropped command: ‘t’ (gnugo-toggle-dead-group),
Stefan Monnier <=
- [elpa] externals/gnugo 6c7e102 181/357: [gnugo int] Rename :waitingp to :waiting; save color there., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 425731b 196/357: [gnugo int] Add abstraction: gnugo--ERR-wait, Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 3f3af4b 208/357: [gnugo int] Remove from ‘gnugo-state’ instead of setting to nil., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo f28d241 223/357: [gnugo int] Decruft: Don't set provisional :last-user-bpos., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 8211cb9 224/357: [gnugo int] Couple :center-position and :SZ jamming., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 536960c 230/357: [gnugo int] Fix bug: On -l/--infile, inhibit first move if game over., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 50cc2b3 233/357: [gnugo int] Add abstraction: gnugo--q/ue, Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 3903907 235/357: [gnugo] Validate position arg of GTP commands ‘undo’, ‘gg-undo’., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo ab1f4c2 242/357: [gnugo] Fix bug: DTRT for suggestion ‘nowarp’ check., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo e814724 243/357: [gnugo] Allow user to request suggestion for GNU Go., Stefan Monnier, 2020/11/29