[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/gnugo 52251ac 270/357: [gnugo int] Move karma state nor
From: |
Stefan Monnier |
Subject: |
[elpa] externals/gnugo 52251ac 270/357: [gnugo int] Move karma state normalization down-chain. |
Date: |
Sun, 29 Nov 2020 14:51:37 -0500 (EST) |
branch: externals/gnugo
commit 52251aceccfb8981962f4b7071a897213dc4d46a
Author: Thien-Thi Nguyen <ttn@gnu.org>
Commit: Thien-Thi Nguyen <ttn@gnu.org>
[gnugo int] Move karma state normalization down-chain.
* packages/gnugo/gnugo.el (gnugo--karma): Always return boolean.
(gnugo--assist-state, gnugo--struggle): Don't normalize here.
---
gnugo.el | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/gnugo.el b/gnugo.el
index d453d78..9f475dc 100644
--- a/gnugo.el
+++ b/gnugo.el
@@ -1726,15 +1726,15 @@ cursor to the suggested position. Prefix arg inhibits
warp."
'nowarp
t)))
-(defun gnugo--karma (color)
- (member color (cdr (gnugo-get :wheel))))
+(defun gnugo--karma (color) ; => BOOL
+ (when (member color (cdr (gnugo-get :wheel)))
+ t))
(defsubst gnugo--:karma (role)
(gnugo--karma (gnugo-get role)))
(defun gnugo--assist-state (&optional gate)
- (let ((bool (when (gnugo--:karma :user-color)
- t)))
+ (let ((bool (gnugo--:karma :user-color)))
(if (and bool gate)
(user-error "Sorry, Assist mode enabled")
bool)))
@@ -2339,10 +2339,7 @@ If COMMENT is nil or the empty string, remove the
property entirely."
(gnugo--decorate node :C comment)))
(defun gnugo--struggle (prop updn)
- (unless (eq ; drudgery avoidance
- (when (gnugo--:karma prop) ; normalize
- t)
- updn)
+ (unless (eq updn (gnugo--:karma prop)) ; drudgery avoidance
(let ((color (gnugo-get prop)))
(if updn
;; enable
- [elpa] externals/gnugo bc92d6d 202/357: [gnugo frolic] Type ‘Q’ to quit., (continued)
- [elpa] externals/gnugo bc92d6d 202/357: [gnugo frolic] Type ‘Q’ to quit., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo a3baa99 200/357: [gnugo int] Use ‘following-char’ more., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo e644695 203/357: [gnugo] Increase S/N for ‘C-u F’ comment., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 7b29f73 219/357: [gnugo int] Decruft: Don't stash :proc-args., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 12d3d80 216/357: [gnugo] Keep GNUGO Board buffer read-only., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 4b6e204 221/357: [gnugo int] Move some prop jamming to ‘gnugo-board-mode’., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo d52bbc7 222/357: [gnugo int] Add abstraction: gnugo--nquery, Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo e837853 226/357: [gnugo int] Declare ‘lexical-binding: t’., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo bc4abdc 238/357: [gnugo int] Centralize some "No stone at POS" errors., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 78edde4 247/357: [gnugo maint] Update HACKING; nfc., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 52251ac 270/357: [gnugo int] Move karma state normalization down-chain.,
Stefan Monnier <=
- [elpa] externals/gnugo 5a201a8 286/357: [gnugo] Fix bug: For GTP "help COMMAND", leave point in right place., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 3540673 272/357: [gnugo] Make SGF I/O commands change ‘default-directory’., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo ac1adcd 276/357: [gnugo] Make ‘gnugo-xpms’ a normal var; drop it as feature., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 079b73c 279/357: [gnugo int] Commentary munging; nfc., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo de92f27 296/357: [gnugo imgen] Add autoload cookie., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 7db9d5e 295/357: [gnugo] Declare package keywords., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo ab69d4b 294/357: [gnugo frolic] Promote frolic mode/funcs to feature., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 91f2d79 318/357: [gnugo int] Avoid latent order-of-evaluation error., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo b086082 321/357: Add some THANKS files; nfc., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 4c07c67 320/357: [gnugo int] Revert bogus OoE avoidance fix, w/ better comment., Stefan Monnier, 2020/11/29