[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/gnugo 4c07c67 320/357: [gnugo int] Revert bogus OoE avo
From: |
Stefan Monnier |
Subject: |
[elpa] externals/gnugo 4c07c67 320/357: [gnugo int] Revert bogus OoE avoidance fix, w/ better comment. |
Date: |
Sun, 29 Nov 2020 14:51:48 -0500 (EST) |
branch: externals/gnugo
commit 4c07c67e972d196fee5ac648ec3a6c26a3342988
Author: Thien-Thi Nguyen <ttn@gnu.org>
Commit: Thien-Thi Nguyen <ttn@gnu.org>
[gnugo int] Revert bogus OoE avoidance fix, w/ better comment.
Looks like 2017-01-31, "Avoid latent order-of-evaluation error"
is just so much mollycoddling. Elegance wins after all. :-D
* packages/gnugo/packages/gnugo/gnugo.el (gnugo--decorate): Revert to use
‘cons’ w/ sibling ‘pop’ calls as args. Reported by Stefan Monnier,
<http://lists.gnu.org/archive/html/emacs-devel/2017-01/msg00779.html>.
---
gnugo.el | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/gnugo.el b/gnugo.el
index ada6fd9..0c84732 100644
--- a/gnugo.el
+++ b/gnugo.el
@@ -898,15 +898,12 @@ For all other values of RSEL, do nothing and return nil."
while plist
do (setf
fruit (list
- ;; Albeit elegant, this assumes LtR OoE, unfortunately.
- ;;- (cons
- ;; (pop plist)
- ;; (pop plist))
- ;; Instead, we use ‘let*’ for explicit sequencing.
- ;; Let the Scheme-based Emacs hacking proceed apace!
- (let* ((k (pop plist))
- (v (pop plist)))
- (cons k v)))
+ ;; No OoE worries, here. "The first step in evaluating a
+ ;; function call is to evaluate the remaining elements of the
+ ;; list from left to right." (info "(elisp) Function Forms")
+ (cons
+ (pop plist)
+ (pop plist)))
(cdr tp) fruit
tp fruit)))
- [elpa] externals/gnugo 52251ac 270/357: [gnugo int] Move karma state normalization down-chain., (continued)
- [elpa] externals/gnugo 52251ac 270/357: [gnugo int] Move karma state normalization down-chain., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 5a201a8 286/357: [gnugo] Fix bug: For GTP "help COMMAND", leave point in right place., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 3540673 272/357: [gnugo] Make SGF I/O commands change ‘default-directory’., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo ac1adcd 276/357: [gnugo] Make ‘gnugo-xpms’ a normal var; drop it as feature., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 079b73c 279/357: [gnugo int] Commentary munging; nfc., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo de92f27 296/357: [gnugo imgen] Add autoload cookie., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 7db9d5e 295/357: [gnugo] Declare package keywords., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo ab69d4b 294/357: [gnugo frolic] Promote frolic mode/funcs to feature., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 91f2d79 318/357: [gnugo int] Avoid latent order-of-evaluation error., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo b086082 321/357: Add some THANKS files; nfc., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 4c07c67 320/357: [gnugo int] Revert bogus OoE avoidance fix, w/ better comment.,
Stefan Monnier <=
- [elpa] externals/gnugo 5383e47 326/357: [gnugo int] Shirk syntax, abbrev tables in Gnugo Board mode., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo e5cba8f 344/357: [gnugo] Formalize game-over "group"; use symbolic color., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo a38cd9e 348/357: [gnugo int] Comment munging; nfc., Stefan Monnier, 2020/11/29