emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/idris-mode 8329b73be8 3/6: Move "words of encouragement" f


From: ELPA Syncer
Subject: [nongnu] elpa/idris-mode 8329b73be8 3/6: Move "words of encouragement" from minibuffer to Idris repl banner
Date: Fri, 18 Nov 2022 05:59:08 -0500 (EST)

branch: elpa/idris-mode
commit 8329b73be8f16012f340af2825278c55ce235ac8
Author: Marek L <nospam.keram@gmail.com>
Commit: Marek L <nospam.keram@gmail.com>

    Move "words of encouragement" from minibuffer to Idris repl banner
    
    Why:
    To split concerns of "logging that Idris connection was created" and
    displaying "words of encouragement for user".
    To ensure that the words of encouragement are visible to user.
    
    Relates to:
    https://github.com/idris-hackers/idris-mode/pull/564
---
 idris-repl.el     | 4 +++-
 inferior-idris.el | 4 +---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/idris-repl.el b/idris-repl.el
index aaebbecd2b..81d10d366c 100644
--- a/idris-repl.el
+++ b/idris-repl.el
@@ -96,7 +96,9 @@ Returns non-`nil' on success, `nil' on failure."
                  version-string)
         (insert (propertize (concat "Idris " version-string)
                             'face 'italic)
-                "\n\n")))))
+                "\n")))
+    (when idris-display-words-of-encouragement
+      (insert (idris-random-words-of-encouragement) "\n"))))
 
 (defun idris-repl-insert-prompt (&optional always-insert)
   "Insert or update Idris prompt in buffer.
diff --git a/inferior-idris.el b/inferior-idris.el
index a74b573ba8..43bc7fac80 100644
--- a/inferior-idris.el
+++ b/inferior-idris.el
@@ -141,9 +141,7 @@ directory variables.")
     (set-process-query-on-exit-flag idris-connection t)
     (setq idris-process-current-working-directory "")
     (run-hooks 'idris-run-hook)
-    (when idris-display-words-of-encouragement
-      (message "Connected. %s" (idris-random-words-of-encouragement)))
-    ))
+    (message "Connection to Idris established.")))
 
 (defun idris-sentinel (_process msg)
   (message "Idris disconnected: %s" (substring msg 0 -1))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]