[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/idris-mode 62c3ad2b0d 2/6: Make empty string always return
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/idris-mode 62c3ad2b0d 2/6: Make empty string always return value from `idris-process-filter` |
Date: |
Fri, 18 Nov 2022 05:59:08 -0500 (EST) |
branch: elpa/idris-mode
commit 62c3ad2b0d67c376b5d5d1ce894ad9942531769c
Author: Marek L <nospam.keram@gmail.com>
Commit: Marek L <nospam.keram@gmail.com>
Make empty string always return value from `idris-process-filter`
Why:
In commit: 74731b53caa6b2a2a was introduced regression by moving the ""
inside of the if expression causing it being return value only in some
cases.
The return value from idris-process-filter is written into idris-process
buffer and
after commit 74731b5 this become mostly the output of idris-connect
which consequently returns idris-words-of-encouragement.
Because now the *idris-process* buffer is not empty it is moved to the
front and interrupts users workflow.
Downside of this fix is that the words of encouragement
may be lost from users sight due to another messages when loading
file to Idris. This will be addressed in separate commit.
---
inferior-idris.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/inferior-idris.el b/inferior-idris.el
index a74b573ba8..7e313552dd 100644
--- a/inferior-idris.el
+++ b/inferior-idris.el
@@ -189,8 +189,8 @@ directory variables.")
(if (not (string-match idris-process-port-with-warning-output-regexp
string))
(idris-warn string)
(idris-warn (match-string idris-warning-matcher string))
- (idris-connect (string-to-number (match-string
idris-warning-port-matcher string))))
- ""))))
+ (idris-connect (string-to-number (match-string
idris-warning-port-matcher string)))))
+ "")))
(defun idris-show-process-buffer (string)
"Show the Idris process buffer if STRING is non-empty."
- [nongnu] elpa/idris-mode updated (1dc558ad24 -> 67e06eccbd), ELPA Syncer, 2022/11/18
- [nongnu] elpa/idris-mode 8329b73be8 3/6: Move "words of encouragement" from minibuffer to Idris repl banner, ELPA Syncer, 2022/11/18
- [nongnu] elpa/idris-mode 3c3a87c66c 1/6: Fix failure to find beginning of function type definition, ELPA Syncer, 2022/11/18
- [nongnu] elpa/idris-mode 43e8a6e723 5/6: Merge pull request #564 from keram/fix-encouragement-in-process-buffer, ELPA Syncer, 2022/11/18
- [nongnu] elpa/idris-mode ca860db9ae 4/6: Merge pull request #562 from keram/make-lemma-underscore, ELPA Syncer, 2022/11/18
- [nongnu] elpa/idris-mode 67e06eccbd 6/6: Merge pull request #565 from keram/words-of-encouragement-in-repl-banner, ELPA Syncer, 2022/11/18
- [nongnu] elpa/idris-mode 62c3ad2b0d 2/6: Make empty string always return value from `idris-process-filter`,
ELPA Syncer <=