emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/idris-mode 62c3ad2b0d 2/6: Make empty string always return


From: ELPA Syncer
Subject: [nongnu] elpa/idris-mode 62c3ad2b0d 2/6: Make empty string always return value from `idris-process-filter`
Date: Fri, 18 Nov 2022 05:59:08 -0500 (EST)

branch: elpa/idris-mode
commit 62c3ad2b0d67c376b5d5d1ce894ad9942531769c
Author: Marek L <nospam.keram@gmail.com>
Commit: Marek L <nospam.keram@gmail.com>

    Make empty string always return value from `idris-process-filter`
    
    Why:
    In commit: 74731b53caa6b2a2a was introduced regression by moving the ""
    inside of the if expression causing it being return value only in some
    cases.
    The return value from idris-process-filter is written into idris-process
    buffer and
    after commit 74731b5 this become mostly the output of idris-connect
    which consequently returns idris-words-of-encouragement.
    Because now the *idris-process* buffer is not empty it is moved to the
    front and interrupts users workflow.
    
    Downside of this fix is that the words of encouragement
    may be lost from users sight due to another messages when loading
    file to Idris. This will be addressed in separate commit.
---
 inferior-idris.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/inferior-idris.el b/inferior-idris.el
index a74b573ba8..7e313552dd 100644
--- a/inferior-idris.el
+++ b/inferior-idris.el
@@ -189,8 +189,8 @@ directory variables.")
           (if (not (string-match idris-process-port-with-warning-output-regexp 
string))
               (idris-warn string)
             (idris-warn (match-string idris-warning-matcher string))
-            (idris-connect (string-to-number (match-string 
idris-warning-port-matcher string))))
-          ""))))
+            (idris-connect (string-to-number (match-string 
idris-warning-port-matcher string)))))
+        "")))
 
 (defun idris-show-process-buffer (string)
   "Show the Idris process buffer if STRING is non-empty."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]