[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] ox-icalendar: fix handling of timestamps

From: Nicolas Goaziou
Subject: Re: [O] [PATCH] ox-icalendar: fix handling of timestamps
Date: Thu, 15 Aug 2013 09:55:41 +0200

Viktor Rosenfeld <address@hidden> writes:

Thanks for the patch. A small comment follows:

> +                (let ((type (org-element-property :type ts))
> +                      (uid (format "TS%d-%s" (incf counter) uid)))
> +                  (when (or (eq with-timestamps t)
> +                            (and (eq with-timestamps 'active)
> +                                 (memq type '(active active-range)))
> +                            (and (eq with-timestamps 'inactive)
> +                                 (memq type '(inactive 'inactive-range))))
> +                    (org-icalendar--vevent entry ts uid summary loc desc 
> cat))))

This is not correct since COUNTER is increased before we know if the
VEVENT will be created. IOW, (let ((uid ...))) should be moved after the


Nicolas Goaziou

reply via email to

[Prev in Thread] Current Thread [Next in Thread]