[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Fix error prone babel table output format detection

From: Ian Kelling
Subject: Re: [O] [PATCH] Fix error prone babel table output format detection
Date: Wed, 07 May 2014 13:57:42 -0700
User-agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.4.50 (gnu/linux)

Eric Schulte <address@hidden> writes:

> This looks good to me.  Could you reformat the patch with
>   git format-patch
> and attach the results (this will be easier to apply).

Done. I was actually following the instructions in man git-format-patch by
not attaching it before, but I will avoid that in future.

> Also, this patch
> is small enough to apply without any sort of copyright attribution, but
> if you think you might make larger contributions in the future, please
> look over the org contribution instructions [1].>

I've completed emacs fsf copyright assignment. I also have another patch
that has been on the mailing list for about 2 weeks or so waiting for a reply.

>From 4122d20f1253c2cbf5e73070ea00665bbc802275 Mon Sep 17 00:00:00 2001
From: Ian Kelling <address@hidden>
Date: Wed, 30 Apr 2014 21:56:52 -0700
Subject: [PATCH] Fix error prone babel table output format detection

* lisp/ob-core.el: Test that all elements are in a list are lists or
'hline instead of just the first.

org-babel table output uses different formatting for a list of lists,
but detects it incorrectly causing an error. An example of a block
causing an error is an emacs lisp source block containing just 1 line:
'((1) 2)
 lisp/ob-core.el |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/ob-core.el b/lisp/ob-core.el
index 1348f04..4ddafaf 100644
--- a/lisp/ob-core.el
+++ b/lisp/ob-core.el
@@ -2184,9 +2184,9 @@ code ---- the results are extracted in the syntax of the 
                 ((funcall proper-list-p result)
                  (goto-char beg)
                  (insert (concat (orgtbl-to-orgtbl
-                                  (if (or (eq 'hline (car result))
-                                          (and (listp (car result))
-                                               (listp (cdr (car result)))))
+                                  (if (org-every
+                                       (lambda (el) (or (listp el) (eq el 
+                                       result)
                                       result (list result))
                                   '(:fmt (lambda (cell) (format "%s" cell)))) 
                  (goto-char beg) (when (org-at-table-p) (org-table-align)))

reply via email to

[Prev in Thread] Current Thread [Next in Thread]