[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store
Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props
Wed, 04 Nov 2015 14:39:01 +0000
Notmuch/0.20.2+65~gbd5504e (http://notmuchmail.org) Emacs/184.108.40.206 (x86_64-unknown-linux-gnu)
2015ko azaroak 4an, Jan Malakhovski-ek idatzi zuen:
>> Also, what is ignore-errors protecting? The call to date-to-time, or
>> format-time-string? I think the scope of ignore-errors should be as
>> narrow as it can be.
> I have no idea. I moved these lines from org-gnus, equivalent lines in
> org-*other-mail-reader*s don't use ignore-errors at all. I don't use
> gnus so went for the safest change.
Checking the source, date-to-time can raise an error (invalid date).
format-time-string is a C function, so it’s less easy for me to
understand. But it looks like if it raises any errors, these are bugs
that we want to know about and not suppress.
The ignore-error call was introduced to org-gnus in commit 0dfde2da.
Based on the commit message, it looks like the problem being solved was
invalid dates getting passed to date-to-time.
So I think the ignore-error can just wrap the date-to-time call.
[O] [PATCH 7/9] org-notmuch: add date support to org-notmuch-store-link, Jan Malakhovski, 2015/11/03
[O] [PATCH 8/9] ob-calc: add more API, documentation and examples so that it can be used in tables, Jan Malakhovski, 2015/11/03
[O] [PATCH 9/9] ob-calc: don't leave garbage on the stack, Jan Malakhovski, 2015/11/03
Re: [O] [PATCH v2 0/9] mail, clock and calc changes, Aaron Ecay, 2015/11/04
- Re: [O] [PATCH 3/9] org-clock: fix `org-clock-time%', (continued)