[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] `org-make-tags-matcher' broken by lexical-binding

From: Nicolas Goaziou
Subject: Re: [O] `org-make-tags-matcher' broken by lexical-binding
Date: Sun, 10 Jan 2016 22:05:32 +0100


Samuel Loury <address@hidden> writes:

> I found out that `org-make-tags-matcher' relies heavily on the dynamic
> binding.

Unfortunately, this is not the only one.

> First of all, it assumes that the `todo-only' variable is scoped
> in. This is simple to fix by making todo-only a parameter of the
> function and fixing the calls.
> Then, it returns a form that relies on the fact that the variables todo
> and tags-list are scoped in. AFAICU, this sounds a bit trickier to fix
> because the usage of the returned "matcher" can be correctly used
> depending on the case.
> For instance, `org-clock-get-table-data' gives to `org-clock-sum' a
> lamdba function that evaluates the obtained matcher.
> The attempt to funcall-ing the lambda in `org-clock-sum' complains that
> tags-list does not exist.
> I probably won't have the time to create a patch for that, so I just
> warn about the problem.
> Hope that helps.

Indeed, I noticed that, too. This is fixed. Thank you.


Nicolas Goaziou

reply via email to

[Prev in Thread] Current Thread [Next in Thread]